chore: Make materializer stackless for obj and arr#620
Draft
He-Pin wants to merge 2 commits intodatabricks:masterfrom
Draft
chore: Make materializer stackless for obj and arr#620He-Pin wants to merge 2 commits intodatabricks:masterfrom
He-Pin wants to merge 2 commits intodatabricks:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors Materializer.apply0 to avoid recursive JVM stack growth when materializing deeply nested objects/arrays, aiming to reduce StackOverflow risk by using an explicit stack.
Changes:
- Replaced recursive object/array materialization with an iterative, stack-based algorithm.
- Added
materializeLeafhelper and stack frame types for object/array traversal. - Added documentation about a supposed TCO boundary and a defensive TailCall check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
He-Pin
force-pushed
the
materializer
branch
8 times, most recently
from
a231a79 to
43bf62b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
sjsonnet/src/sjsonnet/Materializer.scala:22
Materializernow introduces a new abstract methodstorePos(v: Val). BecauseMaterializeris a public abstract class, adding an abstract member is a source/binary breaking change for any downstream code that subclasses it. Consider makingstorePos(v: Val)a concrete (non-abstract) helper that delegates tostorePos(v.pos)(or a default no-op) so existing subclasses continue to compile unchanged.
abstract class Materializer {
def storePos(pos: Position): Unit
def storePos(v: Val): Unit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This can reduce some stack usage of the jvm native frame
refs:google/jsonnet#1142
based on #619
Which should be slightly slower? So I have to use a hybrid strategy.
on main
with this